fix: import the fractor configuration if found in fractor.php file#5
Closed
mgerdes-atl wants to merge 3 commits intoandreaswolf:mainfrom
Closed
fix: import the fractor configuration if found in fractor.php file#5mgerdes-atl wants to merge 3 commits intoandreaswolf:mainfrom
mgerdes-atl wants to merge 3 commits intoandreaswolf:mainfrom
Conversation
Otherwise there was an error: ```FRACTOR: Fatal error: Uncaught TypeError: a9f\Fractor\Configuration\FractorConfigurationBuilder::__invoke(): Argument andreaswolf#1 ($containerConfigurator) must be of type Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator, a9f\Fractor\Configuration\FractorConfigurationBuilder given, called in /var/www/html/lifter/vendor/a9f/lifter/res/run_fractor.php on line 19 and defined in /var/www/html/lifter/vendor/a9f/fractor/src/Configuration/FractorConfigurationBuilder.php:49```
adjust composer dependency to allow a9f/fractor version ^0.4
Owner
|
Thanks for the contribution. I reworked the PR branch to remove the merge of main, and adjusted the commit messages; however, I could not push to the PR, so I instead put the branch into my repo as |
Owner
|
Closing this in favor of #13 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @andreaswolf ,
thanks for the inspiring speech at t3chh .
I just wanted to try out the lifter including fractor and came across the error
FRACTOR: Fatal error: Uncaught TypeError: a9f\Fractor\Configuration\FractorConfigurationBuilder::__invoke(): Argument #1 ($containerConfigurator) must be of type Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator, a9f\Fractor\Configuration\FractorConfigurationBuilder given, called in /var/www/html/lifter/vendor/a9f/lifter/res/run_fractor.php on line 19 and defined in /var/www/html/lifter/vendor/a9f/fractor/src/Configuration/FractorConfigurationBuilder.php:49I change the run_fractor to use import method. Hopefully that should do the trick